Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for viewing graphs in plotly through the last graph menu #7990

Merged
merged 5 commits into from Nov 29, 2022

Conversation

Patowhiz
Copy link
Contributor

Fixes partly issue #5706
@africanmathsinitiative/developers this is ready for review.
@rdstern I've added Plotly support for "last graph".

@rdstern
Copy link
Collaborator

rdstern commented Nov 28, 2022

@Patowhiz it seems to go into the plotly fine.
And it saves as html - perfect.
But the saving as html gives the large number of files, similar to pivotTable did, before you fixed it. So I don't know how to open it as html then.

@Patowhiz
Copy link
Contributor Author

@rdstern this PR did not have changes made in PR #7987. I have now included those changes as well. You can now test it. Thanks.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine and is another Wow, in the new version.
Ironic that this wow is to use html in a browser, when the main aim is to eliminate our dependence on that. @lloyddewit over to you

@lloyddewit lloyddewit mentioned this pull request Nov 29, 2022
@lloyddewit lloyddewit changed the title Adds support for viewing graphs in plotly through the last graph menu Added support for viewing graphs in plotly through the last graph menu Nov 29, 2022
@lloyddewit lloyddewit merged commit c4e9c0d into IDEMSInternational:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants