Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argentina Mobile and SMS #18

Closed
allendav opened this issue May 7, 2015 · 3 comments · Fixed by #21
Closed

Argentina Mobile and SMS #18

allendav opened this issue May 7, 2015 · 3 comments · Fixed by #21

Comments

@allendav
Copy link
Contributor

allendav commented May 7, 2015

We're using the library to validate SMS phone numbers, and Argentinian SMS has a wrinkle - it doesn't support the leading 9, per http://en.wikipedia.org/wiki/Telephone_numbers_in_Argentina#Inbound_SMS

Also, it looks like Argentinian numbers can be 6, 7 or 8 digits long. I'm curious about the 10 in the code:

country_code: "54", country_name: "Argentina", mobile_begin_with: ["9"], phone_number_lengths: [10]

Would you entertain a pull request that removes the mobile_begin_with 9 requirement and replaces the 10 with 6, 7, 8, 9 (to cover whether or not the leading 9 is present). Or is there a better approach to fix this?

@cilindrox
Copy link

👍 struggling with the same problem

@mypark
Copy link

mypark commented Jun 4, 2015

I'm having the same issue as well

@brunocascio
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants