[DO NOT MERGE] Code Review #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import pandas as pd | ||
| import matplotlib.pyplot as plt | ||
| import statsmodels.api as sm | ||
| import seaborn as sb |
There was a problem hiding this comment.
There are a lot of unused imports. Some of them (e.g. np) are fine for exploration, but I'm not sure why we need os
There was a problem hiding this comment.
The standard abbreviation for seaborn is
import seaborn as snsand not
import seaborn as sb(Don't ask me why).
|
|
||
| def floor_plot(*args, **kwargs): | ||
| group = kwargs.pop('group', None) | ||
| group_word = {None:"", "week":"Weekly ", "day":"Daily "} |
There was a problem hiding this comment.
You want spaces between the colon and the value:
group_word = {None: "", "week": "Weekly", ...}
^ ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've exported your notebook to go through some code review.
density.ipynbhas my combined changes, whiledensity.pyis your original code (and is where my comments are)In general, try to adhere to pep8 for formatting.