Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Any way to not init ToolPanelComp? #61

Closed
billyvg opened this issue Aug 25, 2016 · 3 comments
Closed

Any way to not init ToolPanelComp? #61

billyvg opened this issue Aug 25, 2016 · 3 comments

Comments

@billyvg
Copy link

billyvg commented Aug 25, 2016

We are passing showToolPanel: false, but is there a way to completely disable it and not render/initialize at all? ColumnSelectPanel is causing very poor performance issues and since we don't use the tool panel, we would like to make sure it doesn't render at all.

Timeline:

image

@ceolter
Copy link
Collaborator

ceolter commented Aug 31, 2016

what type of performance issues? i mean, are you talking milliseconds that are hardly noticeable, or seconds?

@billyvg
Copy link
Author

billyvg commented Aug 31, 2016

It's significant, the screenshot I posted it from a 2015 MBP and it's 400ms

@ceolter
Copy link
Collaborator

ceolter commented Sep 2, 2016

i have now put lazy initialisation into the toolPanel. if not showing by default, it doesn't get initialised.

i tested this on the main demo page, and then show toolPanel in a timeout 1 second after page is shown. the time for the whole api.showToolPanel(true) to execute was 80ms. maybe i'm on a faster computer.

@ceolter ceolter closed this as completed Sep 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants