Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filtering - groups] Filtering is not working in Master Detail Grids #1324

Closed
bamminger opened this issue Dec 9, 2016 · 12 comments
Closed

Comments

@bamminger
Copy link

When using a master detail grid, the filter of all columns is empty.
Demo can be found on the ag-grid website.
When disabling getNodeChildDetails the filter works as expected.

grafik

@ceolter
Copy link
Contributor

ceolter commented Jan 4, 2017

verified and this is true. i've updated the example to remove filtering.

the problem is filters work at the leaf level. this only makes sense when the parent rows are aggregations of the child rows. there is another issue open to allow filtering on the group node, until this is done, this will remain to not work.

@ceolter ceolter changed the title Filtering is not working in Master Detail Grids [filtering - groups] Filtering is not working in Master Detail Grids Jan 20, 2017
@MolallaComm
Copy link

Just ran into this issue myself - +1 for a fix. I like the way master detail works - i was able to easily display multiple related tables using an ionic segment bar and odata - but filtering/grouping not working on the master when using master detail is enabled unfortunately may be a deal breaker for us.

image

@helgenlechner
Copy link

Running into this as well. We have an enterprise license as well and would like to see this fixed soon. Thank you!

@bamminger
Copy link
Author

bamminger commented Apr 21, 2017

Have you tried this workaround? https://ag-grid.com/forum/showthread.php?tid=5135

@MolallaComm
Copy link

Thanks so much for that work around - I can confirm that it does allow the default enterprise set filters to work normally, so that is a step in the right direction - but alas it does not seem to fix grouping. Here is my getNodeChildDetails function FWIW:

  public getNodeChildDetails(record) {
    if (record.IsChild) {
      return null;
    }
    else {
      let set = (<any>this).gridOptionsWrapper.gridOptions.context.navParams.data.Set;
      record["IsChild"] = true;
      return {
        group: true,
        // the key is used by the default group cellRenderer
        key: record[set.Keys[0]],  // hack - need to test if it works with for records that use composite keys - hopefully you can just pass in an array of colIds?
        // provide ag-Grid with the children of this group -
        children: [record]   // this is a hack to make grouping/filtering work with master detail
      };
    }
  }

And here is what it looks like when I try to group:

image

I'm not familiar enough with their data model yet, but seems like this should be able to work - it is not different than grouping by first one column and then another - but it seems to be reusing the children instead of creating a new group level from the parent?

@makinggoodsoftware
Copy link
Contributor

This should be fixed now

@bamminger
Copy link
Author

bamminger commented Dec 19, 2017

@makinggoodsoftware Included in v15?

@hetal1110
Copy link

hetal1110 commented Feb 23, 2018

@makinggoodsoftware Included in v15?

As we are facing the same issue, in master detail grid filter is not working..

After applying filter, I am not able expand the child grid.

Please suggest any workaround for this.

@ghetal
Copy link

ghetal commented Feb 23, 2018

I am facing the same issue. Aftre filtering master grid, expanding child grid doesn't work.
Is it fixed now?

@hetal1110
Copy link

Any Updates?

@prafful-garg
Copy link

I am also facing the same issue, i have enterprise license for the grid

@bamminger
Copy link
Author

I haven't checked if the bug was fixed. For all of you who have an enterprise license, just create an open issue in the enterprise support portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants