Runtime permissions request (for Android 6 only) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See agamemnus#94 In Android 6 (and only Android 6) we need WRITE_EXTERNAL_STORAGE permission in order to read the OBB file. This is a known Android 6 bug; the OBB file is supposed to be part of the app's internal storage. See https://code.google.com/p/android/issues/detail?id=197287 In Android target api >= 23, WRITE_EXTERNAL_STORAGE is considered part of the "dangerous" STORAGE permissions group. So, instead of asking the user to grant it when the app is installed/upgraded, we have to prompt the user for it at runtime. That's what this patch adds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #94
In Android 6 (and only Android 6) we need WRITE_EXTERNAL_STORAGE
permission in order to read the OBB file. This is a known Android
6 bug; the OBB file is supposed to be part of the app's internal
storage. See https://code.google.com/p/android/issues/detail?id=197287
In Android target api >= 23, WRITE_EXTERNAL_STORAGE is considered
part of the "dangerous" STORAGE permissions group. So, instead of
asking the user to grant it when the app is installed/upgraded, we
have to prompt the user for it at runtime. That's what this patch
adds.