Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify profile data display and use user.photoURL for profile… #293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0rigin-c0de
Copy link

Screenshot 2023-08-02 112527

Pull Request Template

Description

  • Updated the profile component to directly access the user's display name, description, and profile picture URL from the user object obtained through the useAuth hook.
  • Changed the way the user's profile picture is displayed using user.photoURL property from the authentication system.

Fixes #286

Type of change

Using user.photoURL:

The user's profile picture is now displayed using user.photoURL, which is a property provided by the authentication system. This ensures that the profile picture is always up to date and associated with the authenticated user.

Refactoring and Simplification:

The code was refactored to simplify the way user data (display name, description, and profile picture URL) is accessed and updated. Instead of using separate state variables, the user object obtained from the useAuth hook is directly used to access this data, which results in cleaner code.

Elimination of Unused Code:

Some comments and imports that were no longer used were removed from the code, which helps keep the codebase tidy and more maintainable.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pollitup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 6:12am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile info not visible
1 participant