Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail well #2

Closed
sckott opened this issue Mar 26, 2017 · 3 comments
Closed

fail well #2

sckott opened this issue Mar 26, 2017 · 3 comments

Comments

@sckott
Copy link

sckott commented Mar 26, 2017

to fail well for a nice user experience, maybe validate ORCID ID input? maybe there's a shiny widget that does that kind of thing already? or just do manually, e.g., right now 0000-0001-6339-03745 gives Error: 404 - Not found : No entity found for query which I understand, but i imagine others won't know what they did wrong (in this case just an extra digit on the end of the ID)

@agbarnett
Copy link
Owner

I've added some basic checks, but I can't get them to appear on the page. The warnings are passed to the orcid function, but don't appear in the output. I can't work out why.

@sckott
Copy link
Author

sckott commented Mar 28, 2017

hmm, i'm no shiny expert, i'll see if I find anything about displaying Shiny errors

@agbarnett
Copy link
Owner

Fixed now using the "validate" option in shiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants