-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to standard library 1.5 #242
Comments
Yes, indeed it should. I welcome even partial PRs on this. I'm not likely to get time to fix this for at least 10 days. |
I'm a bit curious about the change of the definition of Would it not have been possible to keep both versions in the stdlib? Or at least add some helper functions/smart constructors that compute the redundant fields? |
Just to be clear, if an order morphism goes between two posets (as opposed to preorders) then the |
Like what other helpers? |
Like |
... or
There's lots of them in |
Maybe it makes sense to have it as well in |
Yes, to both. So the old definition wasn't usable in many important cases because you didn't actually know that one of the relations was a poset and the point of establishing the morphism was to transfer the properties across in (see I'll add the bundles and smart constructors to |
Opened agda/agda-stdlib#1407 to address this. |
Splendid, thanks @MatthewDaggitt! |
Will you prepare a new release for agda-categories? |
Yes. But first I was to bring in PR #240 as it seems ready. |
Awesome that this could be fixed so quickly! :-) How can I help with PR #240? Cutting a new release of agda-categories, compatible with standard-library 1.5, is the last thing to be done before we can release the new standard-library in Nix. :-) (We strive to offer an all-compatible package set, hence updating just standard-library but not agda-categories is not an option.) |
The PR has been merged in now. |
Super awesome, thank you very much Jacques! I'll immediately prepare the update for Nix. |
The standard library has been released at version 1.5 agda/agda-stdlib#1386 🎉
It was noticed by @iblech in NixOS/nixpkgs#110830 that
agda-categories
uses the moduleRelation.Binary.OrderMorphism
which has been deprecated. This should probably be fixed?The text was updated successfully, but these errors were encountered: