Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for supporting GHC 8.0.1 #1799

Closed
asr opened this issue Jan 26, 2016 · 15 comments
Closed

Preparation for supporting GHC 8.0.1 #1799

asr opened this issue Jan 26, 2016 · 15 comments
Assignees
Labels
ghc support Changes to supported GHC versions ghc-8.0.1 type: enhancement Issues and pull requests about possible improvements ux: installation Getting Agda set up on your machine

Comments

@asr
Copy link
Member

asr commented Jan 26, 2016

Last edit: 2016-05-01
GHC version: 8.0.1-rc4

Current issues related to support GHC 8.0.1:

@asr asr added type: enhancement Issues and pull requests about possible improvements ux: installation Getting Agda set up on your machine GHC-8.0.1-RC1 labels Jan 26, 2016
@asr asr self-assigned this Jan 26, 2016
@asr asr changed the title Preparation for supporting GHC 8 Preparation for supporting GHC 8.0.1 Feb 7, 2016
@asr
Copy link
Member Author

asr commented Feb 20, 2016

I updated the OP.

2 similar comments
@asr
Copy link
Member Author

asr commented Feb 22, 2016

I updated the OP.

@asr
Copy link
Member Author

asr commented Apr 18, 2016

I updated the OP.

@mietek
Copy link
Contributor

mietek commented Apr 20, 2016

There appears to be an issue with compiling agda-mode using GHC 8.0.1-rc3, as reported in Homebrew/homebrew-core#440 (comment) by @ilovezfs:

==> /usr/local/Cellar/agda/2.5.1/bin/agda-mode compile
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Symbol's function definition is void: byte-compile-disable-warning
Unable to compile the following Emacs Lisp files:
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda2-abbrevs.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/annotation.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda2-queue.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/eri.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda2.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda-input.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda2-highlight.el
  /usr/local/Cellar/agda/2.5.1/share/x86_64-osx-ghc-8.0.0.20160411/Agda-2.5.1/emacs-mode/agda2-mode.el
/usr/local/Library/Homebrew/debrew.rb:11:in `raise'
BuildError: Failed executing: /usr/local/Cellar/agda/2.5.1/bin/agda-mode compile

@ilovezfs
Copy link

@mietek Thank you for reporting this in the right place!

@asr
Copy link
Member Author

asr commented Apr 20, 2016

@mietek I couldn't reproduce the issue with GNU Emacs 24.5.1. As it was mentioned by @zmwangx, the issue doesn't depend on GHC 8.0.1-rc3.

@ilovezfs
Copy link

The formula for agda only requires

 depends_on :emacs => ["21.1", :recommended]

The version that ships on El Capitan is 22.1.1.

@asr Given that the issue does not occur when using agda 2.5.1 + ghc-7.10.3b + emacs 22.1.1, and it does occur when using agda 2.5.1 + ghc 8.0.1-rc3 + emacs 22.1.1, there's clearly some sort of difference.

@zmwangx
Copy link

zmwangx commented Apr 21, 2016

Emacs 22.1.1 from 2007 doesn't seem to have byte-compile-disable-warning. I'm surprised that it worked at all.

Anyway, assuming that agda2-mode is supported on 22.1.1 (I doubt it, because even some big name packages like magit have long since moved on), we can safely ignore the error, because the only difference between byte compiling or not is speed.

@ilovezfs
Copy link

@zmwangx well that would mean the bug is with 7.10.3b not failing. Also it means that if the formula is going to have an emacs option it should be requiring a higher version if 22.1.1 is not sufficient.

@asr
Copy link
Member Author

asr commented Apr 21, 2016

I filed #1945 for continuing the discussion with the issue with agda-mode.

@ilovezfs
Copy link

@zmwangx Yep you were right. The issue is that --build-bottle fulfills the requirement :emacs => ["21.1", :recommended] with brew's emacs, which is 24.5, whereas --build-from-source fulfills the same requirement with the system emacs, which is 22.1.1. Despite the error, do the compiled agda emacs bindings from the bottle work with 21.1.1 at all? If not we really should raise that requirement to whatever is the minimum that does actually work.

@asr
Copy link
Member Author

asr commented Apr 21, 2016

Since Agda compiles with GHC 8.0.1-rc3 and I didn't find any problem running make test I'm closing this issue. I'll open new issues for other problems known.

@asr asr closed this as completed Apr 21, 2016
@asr
Copy link
Member Author

asr commented Apr 23, 2016

Agda doesn't compile with GHC 8.0.1-rc4. I updated the OP.

@asr asr reopened this Apr 23, 2016
@asr
Copy link
Member Author

asr commented May 2, 2016

The murmur-hash issue was fixed, I updated the OP.

@asr
Copy link
Member Author

asr commented May 12, 2016

GHC 8.0.1 (source tarball) was released, so I'm closing this issue. Please use #1971 for reporting new issues related to this version of GHC.

@asr asr closed this as completed May 12, 2016
@rwe rwe added the ghc support Changes to supported GHC versions label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc support Changes to supported GHC versions ghc-8.0.1 type: enhancement Issues and pull requests about possible improvements ux: installation Getting Agda set up on your machine
Projects
None yet
Development

No branches or pull requests

5 participants