Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify extra condition on transp #4914

Merged
merged 1 commit into from Oct 7, 2020
Merged

Clarify extra condition on transp #4914

merged 1 commit into from Oct 7, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Sep 7, 2020

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the documentation! I had some small comments about wording

doc/user-manual/language/cubical.lagda.rst Outdated Show resolved Hide resolved
doc/user-manual/language/cubical.lagda.rst Outdated Show resolved Hide resolved
@turion
Copy link
Contributor Author

turion commented Sep 10, 2020

@mortberg Thanks, this improved my patch! Updated and rebased.


* If ``r`` is ``i0`` then ``A`` can be anything, since this side
condition is vacuously true.

* If ``r`` is ``i1`` then ``A`` must be a constant function.

* If ``r`` is some in-scope variable ``i`` then ``A`` only needs to be
* If ``r`` is some in-scope variable ``i`` on which ``A`` depends as well, then ``A`` only needs to be
a constant function when substituting ``i1`` for ``i``.
Copy link
Contributor

@Saizan Saizan Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the condition is still relevant even if A does not mention i, e.g. suppose we are in a context with variables, A : I -> Set, i : I, and x : A i0 then transp A i x will not typecheck. Or did you mean something else by this edit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saizan I thought that this case is covered in the previous bullet points, but I'm probably wrong then. How about "on which A may depend as well"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous bullet points do not cover the case where "r" is a variable in scope like "i".

Also, was the use of "convertible" rather than "equal" intentional? I'm not sure if "convertibility" is defined in the documentation anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but would my new formulation be good?

Also, was the use of "convertible" rather than "equal" intentional? I'm not sure if "convertibility" is defined in the documentation anywhere.

Thanks for asking. Yes, "convertible" is presumably more precise because "equal" can mean so many things (starting with definitially vs. propositionally), and the whole point here is to make it more precise. But to be honest I don't know what "convertible" means or where it is defined. @mortberg do you have a hint?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "definitionally/judgmentally equal" is better than "convertible". I don't know what is used elsewhere in the documentation for this equality

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new formulation would be good. Whether "A" depends or not on "i" is not strictly relevant to the condition, but I guess for transp A i to typecheck either A is always a constant function or it will mention i.

I imagine other readers would also not know about convertibility, I would rather use definitionally equal which is more descriptive at least.

@andreasabel andreasabel added this to the 2.6.2 milestone Sep 30, 2020
@andreasabel andreasabel added cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp ux: documentation Issues relating to Agda's documentation labels Sep 30, 2020
@Saizan Saizan merged commit f08027b into agda:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp ux: documentation Issues relating to Agda's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants