Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element API endpoints closes ageddesi/Mocked-API#107 #130

Closed
wants to merge 7 commits into from
Closed

Element API endpoints closes ageddesi/Mocked-API#107 #130

wants to merge 7 commits into from

Conversation

VLN37
Copy link

@VLN37 VLN37 commented Oct 3, 2022

Hey there, happy hacktoberfest!

Contribution guidelines asks for tests but endpoint and test issues are separate, i figured it was ok? Still starting with typescript. Tried some edge cases in insomnia though!

@ageddesi ageddesi changed the base branch from main to v.0.13.0 October 3, 2022 09:05
@VLN37 VLN37 changed the title Element API endpoints closes #107 Element API endpoints closes ageddesi/Mocked-API#107 Oct 3, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 3, 2022

Hey @VLN37
We have updated our codebase to now have tests and swagger is no longer needed to be updated, instead we do OpenAPI comments directly in the API source file.

I have also pointed the merge target to our v0.13.0 which has the latest code on it. If you are able to resolve the conflict and if you have time update with the tests and OpenAPI Comments that would be ace 👍

@VLN37
Copy link
Author

VLN37 commented Oct 3, 2022

I'll see what i can do.

Tried to link to the issue but it didn't work, any ideas on that?

@ageddesi
Copy link
Owner

ageddesi commented Oct 3, 2022

Ahhh I follow what you mean now. If you want to do the tests I can assign that ticket to you as well and I will close them both at the same time for this PR.

@VLN37
Copy link
Author

VLN37 commented Oct 3, 2022

0.13.0 already has commits for the issue i was pushing for... i guess it's whatever now...

Did learn some while at it, good luck fellow.

@VLN37 VLN37 closed this Oct 3, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 3, 2022

Ah sorry @VLN37 there is a lot going on the last 2 days, Thanks for the help. There is always some more smaller tasks if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants