Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Digital currency transaction list endpoint #146

Merged
merged 6 commits into from Oct 12, 2022
Merged

Feat: Digital currency transaction list endpoint #146

merged 6 commits into from Oct 12, 2022

Conversation

filipkujawa
Copy link
Contributor

@filipkujawa filipkujawa commented Oct 3, 2022

Endpoint Summary:
Returns the list of transactions performed by an address
Inspired by the Etherscan accounts endpoint

Related to #14

Endpoint Path:
/currencies/digital-coins/ethereum/tx-list/:address?

**Part of an Example Response: **

{
"blockNumber": "14923692",
"timeStamp": "1654646570",
"hash": "0xaa45b4858ba44230a5fce5a29570a5dec2bf1f0ba95bacdec4fe8f2c4fa99338",
"nonce": "7",
"blockHash": "0x8df71a12a8c06b36c06c26bf6248857dd2a2b75b6edbb4e33e9477078897b282",
"transactionIndex": "27",
"from": "0x9aa99c23f67c81701c772b106b4f83f6e858dd2e",
"to": "0xc5102fe9359fd9a28f877a67e36b0f050d81a3cc",
"value": "0",
"gas": "6000000",
"gasPrice": "125521409858",
"isError": "0",
"txreceipt_status": "1",
"input": "0xa9059cbb000000000000000000000000313143c4088a47c469d06fe3fa5fd4196be6a4d600000000000000000000000000000000000000000003b8e97d229a2d54800000",
"contractAddress": "",
"cumulativeGasUsed": "1977481",
"gasUsed": "57168",
"confirmations": "746430",
"methodId": "0xa9059cbb",
"functionName": "transfer(address _to, uint256 _value)"
}, 

@ageddesi
Copy link
Owner

ageddesi commented Oct 8, 2022

hi @filipkujawa Any updates on this?

@filipkujawa
Copy link
Contributor Author

hi @filipkujawa Any updates on this?

Update on what?

@ageddesi
Copy link
Owner

@filipkujawa I have left comments on the PR that need looking into before we can Merge this code in.

@ageddesi ageddesi changed the base branch from main to dev October 10, 2022 07:25
@filipkujawa
Copy link
Contributor Author

I can't find any comments on the PR

modules/currency/api/currency-routes.ts Show resolved Hide resolved
modules/currency/utils/getDigitalCurrencyTxList.ts Outdated Show resolved Hide resolved
modules/currency/utils/getDigitalCurrencyTxList.ts Outdated Show resolved Hide resolved
modules/currency/api/currency-routes.ts Outdated Show resolved Hide resolved
@ageddesi
Copy link
Owner

Sorry @filipkujawa it appears my comments where in draft mode so was not submitted. This has now been sorted.

ageddesi
ageddesi previously approved these changes Oct 12, 2022
@ageddesi
Copy link
Owner

Hi @filipkujawa Sorry just a final merge conflict for you to resolve and this will go straight in. Great job.

@ageddesi ageddesi merged commit edca02c into ageddesi:dev Oct 12, 2022
@ageddesi
Copy link
Owner

Super work, thank you 👍 Happy Hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants