Add Movies module #252
Merged
Add Movies module #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c on one of the endpoints
|
hi @devrrior Your movie tests seem to be failing. :( |
It's strange when I run the tests that say everything is ok |
|
Hi @ageddesi, I've been running the tests in multiple times and I haven't found any problem. Jest says every tests have been passed.
|
|
Hi @devrrior I have just tried re-running and it failed again, The build issue is something that was fixed recently in dev. Do you have the latest code in this branch? |
ageddesi
approved these changes
Oct 27, 2022
|
Hey @devrrior, I have updated the branch and made the tests pass 👍 Happy hacktoberfest and thank you for all the hard work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added the movies module. I developed two endpoints for this module (list movies and get movie by id). Also, I added OpenApi documentation and tests for routes and utils.
Issue #206