Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a prettier and eslint pre-commit hook #32

Closed
ageddesi opened this issue Aug 30, 2022 · 6 comments · Fixed by #264
Closed

Setup a prettier and eslint pre-commit hook #32

ageddesi opened this issue Aug 30, 2022 · 6 comments · Fixed by #264
Assignees
@utsav00
Labels
good first issue Good for newcomers

Comments

@ageddesi
Copy link
Owner

This will make sure to enforce our coding standards.
@ageddesi ageddesi added the good first issue Good for newcomers label Aug 30, 2022
@utsav00
Copy link
Contributor

utsav00 commented Oct 1, 2022

I'd like to take this up

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 1, 2022

It is yours, please branch from v.0.12.0

@utsav00
Copy link
Contributor

utsav00 commented Oct 1, 2022

I was checking the linter configs out and tried running it. Observed that it is not setup correctly right now. Am I mistaken or should I fix it and push it?
In case of the latter option, shall I push this with the current PR or address it with a new issue?

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 1, 2022

If you could fix it so it is setup correctly that would also be amazing :P

@utsav00
Copy link
Contributor

utsav00 commented Oct 1, 2022

Sure. Then I'll push with the same PR

@utsav00 utsav00 mentioned this issue Oct 23, 2022
Merged
3 tasks
@utsav00
Copy link
Contributor

utsav00 commented Oct 23, 2022

Thank you for your patience. Awaiting review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utsav00 utsav00

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 32: Add a pre-commit hook for lint checking and styling utsav00/Mocked-API
2 participants
@ageddesi @utsav00