add basic support for phone numbers api

[MiTo0o]

• generate random phone number based on country code WIP (LONG list of countries)
• generate random phone number with random format
• generate random IMEI number

[MiTo0o]

was wondering if this looks ok? Phone numbers can also be formatted with dashes like 111-111-111 or with () like (111)-111-111. I currently just left it with spaces like +1 111 111 111.

[MiTo0o]

now that I think about it, my whole approach may have been overkill. Most people probably don't care that much about a specific country's phone number format.

[MiTo0o]

ah, and most countries have many different phone formats locally. I'm just gonna wait for some suggestions.

[ageddesi]

Hi @MiTo0o,
Thank you for the PR, this is great work. I love that you added the ability to have country codes.
In regards to your question about spaces. Can we make it an option in the url. so you can choose the format.

Examples are:
spaces
no-spaces
dashes

What do you think?

[MiTo0o]

Hi @MiTo0o, Thank you for the PR, this is great work. I love that you added the ability to have country codes. In regards to your question about spaces. Can we make it an option in the url. so you can choose the format.

Examples are: spaces no-spaces dashes

What do you think?

Sounds great, I will add those three options.

[MiTo0o]

hey @ageddesi do you think it's ok if we only provide the phone number formats to popular countries for now? It's a lot of work to search every countries phone number format. Some countries also have many different phone number formats.

[ageddesi]

@MiTo0o Hi, do how ever many you like for this step and then please can you raise a ticket for what needs to be done. Hopefully someone else will pick it up as part of Hacktoberfest

[MiTo0o]

@ageddesi Thank you for your patience and quick responses :D. How does it look so far? Is there anything else I should clean up / do. I think I'll take your suggestion and raise a ticket for the rest of the phone number formats.

[MiTo0o]

hey @ageddesi I merged the 0.13.0 branch into mine and found some problems with swagger.json, there were missing/extra commas and there are some duplicate keys. I fixed the commas, but not sure what you want to do with the duplicate keys.

[ageddesi]

Hi @MiTo0o, I have just pulled in a new way of doing the swagger docs.
We now do the openAPI spec directly in the API file itself using comments.
If you update your code to use this you can ignore the swagger.json file as it will auto generate.

[MiTo0o]

oh the openAPI seems so cool, let me check it out and update

[ageddesi]

Thanks @MiTo0o sorry to be a pain, someone kindly finally set it up for me as part of hacktoberfest and handles all the conflicts I have been having

[MiTo0o]

hey @ageddesi its all good :D. I'm always open to learning more. One quick thing, how do I generate swagger with openAPI? and also getting a error in another api route

the Music interface is being imported by also being created again the the same file

[ageddesi]

Hey @MiTo0o I pushed a fix for this a while ago on the v.0.13.0 branch. If not just delete the inline interface.

[ageddesi]

@MiTo0o Once you have added the OpenAPI comments to your api ts file. The next time you run the application and go to the localhost url you will see your changes refelected in the docs.

[MiTo0o]

ok so the thing is my fork only has the main branch, I can't merge 0.13.0 branch into my branch ;(

[ageddesi]

ok no problem, leave it with me 👍 I will get what you have done merged in.

[ageddesi]

@all-contributors please add @MiTo0o for code.

Thanks for the contribution, Happy Hacktoberfest. I hope you will want to do more in our API. If you do like what we are doing please consider staring the repo and joining our Discord channel at https://discord.gg/yxqrkjDR87

[allcontributors]

@ageddesi

I've put up a pull request to add @MiTo0o! 🎉

[MiTo0o]

Thanks for the contribution, Happy Hacktoberfest. I hope you will want to do more in our API. If you do like what we are doing please consider staring the repo and joining our Discord channel at https://discord.gg/yxqrkjDR87

Thank you so much! :D I had a lot of fun