Jest tests #87
Merged
Jest tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gstur docs: add Trigstur as a contributor for code
Fixed some typo
Update README.md
…keabhi docs: add fadkeabhi as a contributor for doc
|
Also as an aside, I'd appreciate it if you merged this asap, just to enforce the testing standards on any outstanding PRs otherwise the gap will just continue to grow! @ageddesi :) |
|
Hi @Sir-Martin-Esq-III Thanks for the hard work on this one. |
Done! Safe travels |
|
@all-contributors please add @Sir-Martin-Esq-III for code, tests |
|
I've put up a pull request to add @Sir-Martin-Esq-III! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jest support and unit tests for the utils and routes at the time of my branches creation,
If I kept doing them for every module that gets added in while my branch is active I'd never get this merged.
Happy to discuss @ageddesi
In total there are 117 tests with some of them being skipped because of bugs in the code
I'd very much like to pick up from here by fixing the bugs or writing more tests for the outstanding modules as I'm on a bit of a hacktoberfest grind at the moment so if this is merged I'll be creating a few issues
Issue: #4