Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should special case rsqrt8 #39

Closed
eschnett opened this issue Oct 31, 2019 · 2 comments
Closed

Tests should special case rsqrt8 #39

eschnett opened this issue Oct 31, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@eschnett
Copy link
Contributor

The test case generator generates special code for rsqrt11. It should probably do the same for rsqrt8.
@gquintin
Copy link
Contributor

gquintin commented Nov 1, 2019

I checked on my laptop and it seems that it does. What to you mean? Anyway concerning tests, the branch power-support improves testing and it will be merge soon with master.

@gquintin gquintin added the question Further information is requested label Nov 1, 2019
@eschnett
Copy link
Contributor Author

eschnett commented Nov 1, 2019

I am referring to lines 268 and 270 on the master branch of egg/gen_tests.py. These lines have special code for rsqrt11, but not for rsqrt8, which might indicate a bug.

@gquintin gquintin added bug Something isn't working and removed question Further information is requested labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eschnett @gquintin