-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.svg files are being placed in wrong location #16
Comments
Technically we never officially supported embedding svg files. So Im changing the label to enhancement. |
Feature added in dotcore64/fontfacegen@d9e87e6 |
Eh... I think this is still a bug. I removed the Here is how my project was compiled after my gulp run.
|
I cannot reproduce this. What are your node, and gulp-fontgen versions? |
|
Try updating to gulp-fontgen 0.1.8 and see if the issue persists. |
No luck... problem persists. 😢 |
Which operating system are you using? |
Docker for Mac (beta) using the I suppose it might be either Docker or the fact that I'm using 4.2... |
If your on Mac this might be related to dotcore64/fontfacegen#24 Ive just pushed the fix for that to npm. Try updating gulp-fontgen to 0.1.9 and see if the issue persists. |
No luck still... I'll see if I can find some time this evening to dive in and see what more debugging I can do. Docker container should be linux based... so I doubt Mac specific issues are relevant here unless for some reason they are being translated through the Docker daemon. |
Alright. Im not sure how this is happening. The target destination for the .svg is derived from the source file name and target destination provided in the configuration lib/fontfacegen.js, lib/configure.js. And this is passed to tt2svg / batik-ttf2svg in lib/ttf2svg.js. the embedding is handled in lib/stylesheets.js and svg encoding in encoding lib/encode.js. drop some breakpoints / console.log()s in and see whats going on. |
Gotcha. One thing to note is that it is duping the |
@tatemz Did you ever take a look at this? |
Fixed by dotcore64/fontfacegen#36 |
Perhaps this is a problem with
fontgen
itself, but all of the .svg files are being generated and placed into the directory from which gulp is running (or rather from where gulp has called node).I have properly configured my task with a valid
dest
option:The text was updated successfully, but these errors were encountered: