Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinate system used in EES #34

Closed
dhixsingh opened this issue May 15, 2018 · 1 comment
Closed

Fix coordinate system used in EES #34

dhixsingh opened this issue May 15, 2018 · 1 comment
Assignees
Projects

Comments

@dhixsingh
Copy link
Contributor

There are various sources of GIS information used in the EES and the projection used can vary quite a lot. At the moment, we try and convert things to latlon and/or utm, which is old legacy code and too vague.

  1. The simulation should have a global CRS setting, so that everything can be projected to that reference system as needed. This should go in the main config such as here:

    <simulation
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="https://github.com/agentsoz/bdi-abm-integration"
    xsi:schemaLocation="https://github.com/agentsoz/bdi-abm-integration ../../xsd/main.xsd">

  2. Each input GIS data file should come with its associated CRS. Again allof these should probably be specified in the same top level config file such as:

    <firefile>
    <name>scenarios/mount-alexander-shire/maldon-600/scenario_fire.json</name>
    <coordinates>latlong</coordinates>
    <format>geojson</format>
    </firefile>

  3. The coordinate system scheme used should be EPSG; the old legacy latlong and utm should be removed;

  4. Wherever there is a need to convert from one CRS to the other, we should use the existing MATSim routines, i.e., something like:

    CoordinateTransformation transform = TransformationFactory.getCoordinateTransformation(
    TransformationFactory.WGS84, scenario.getConfig().global().getCoordinateSystem());

Some things that will be impacted by this change include:

Fire data

We typically convert this into JSON format directly from the Phoenix shapefiles; the coordinate reference system (CRS) used is not always in the attributes table of the shapefile, so this data has to be augmented with CRS information somewhere. This seems to be done in the config such as here:

<firefile>
<name>scenarios/mount-alexander-shire/maldon-600/scenario_fire.json</name>
<coordinates>latlong</coordinates>
<format>geojson</format>
</firefile>

However this does not seem to be fully implemented.

Location data

Such as for evacuation destintations; supplied in the geography.xml; again an attempt to specify the CRS is in the XML such as:

<coordinateSystem>latlong</coordinateSystem>
<destinations>
<location>
<name>Harcourt</name>
<coordinates>255934.018201,5901133.6543</coordinates>
<split>80</split>
</location>

But this seems to be broken (note in the above example that the CRS latlong does not match the coordinates supplied which are in UTM).

MATSim CRS

Note that MATSim uses its own setting for the CRS (which will stay as is), such as here:

@dhixsingh dhixsingh added the ees label May 15, 2018
@dhixsingh dhixsingh self-assigned this May 15, 2018
@dhixsingh dhixsingh added this to To Do in v3.1 via automation May 15, 2018
@dhixsingh
Copy link
Contributor Author

This issue was moved to agentsoz/ees#12

v3.1 automation moved this from To Do to Done Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.1
  
Done
Development

No branches or pull requests

1 participant