Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "response body truncated" warning for HEAD requests #1

Closed
PiotrSikora opened this issue Nov 10, 2011 · 3 comments
Closed

Invalid "response body truncated" warning for HEAD requests #1

PiotrSikora opened this issue Nov 10, 2011 · 3 comments

Comments

@PiotrSikora
Copy link
Contributor

file: lib/Test/Nginx/Socket.pm line: 789

It seems that the warning code misses special case for HEAD requests, something like:

(length $raw == 0 && $method eq 'HEAD')

I've tried to fix this myself, but my Perl-fu fail me on how to get the original request method.

@agentzh
Copy link
Member

agentzh commented Nov 10, 2011

On Thu, Nov 10, 2011 at 3:52 PM, Piotr Sikora
reply@reply.github.com
wrote:

file: lib/Test/Nginx/Socket.pm line: 789

It seems that the warning code misses special case for HEAD requests, something like:

   (length $raw == 0 && $method eq 'HEAD')

I've tried to fix this myself, but my Perl-fu fail me on how to get the original request method.

I've noticed this as well. I'll fix it later today or tomorrow :)

Thanks!
-agentzh

agentzh added a commit that referenced this issue May 11, 2012
…EAD requests. thanks Piotr Sikora for reporting this in github issue #1.
@agentzh
Copy link
Member

agentzh commented May 11, 2012

Sorry for the delay! Already fixed and the test suite of ngx_postgres is now passing without any warnings :)

@agentzh agentzh closed this as completed May 11, 2012
@PiotrSikora
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants