Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Remove sharex=False in figure 2-13? #78

Open
oscark22 opened this issue May 22, 2023 · 1 comment
Open

[IDEA] Remove sharex=False in figure 2-13? #78

oscark22 opened this issue May 22, 2023 · 1 comment

Comments

@oscark22
Copy link

This isn't a bug, but rather a possible suggested improvement. In figure 2-13 the option sharex=False is used to handle a bug that used to occur in matplotlib.

The argument sharex=False fixes a display bug: without it, the x-axis values and label are not displayed (see: pandas-dev/pandas#10611).

That issue has been resolved. So there's no longer the need to include that argument. This is a possible improvement, the code still works perfectly.

@freedomlives
Copy link

I just noticed as well that this is now not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants