song duration

[jxs]

is there a reason for songs not having them? if not I can submit a PR in the next couple days adding them to the formats that support them (from what i see both id3and metaflac have support=
cheers :)

[agersant]

I'm all up for it! The main reason I did not do it earlier is that I found a lot of software doesn't write the duration ID3 value and I didn't want to slow down indexing by having to peek at the audio data .

[jxs]

i am sorry! haven't yet had time to finish this, i'll try to PR tomorrow
(also, thanks for the search!)

[agersant]

No worries! I haven't deployed a build with search on my own 'production' server yet, did you get a chance to test it?

[jxs]

Sorry, this is going to take a lot more, I ingenuously thought that the duration was present on the files metadata but turns out it is not, you have to calculate it from the bitrate and the file size.
The search works pretty flawless from my also short experience, I would just make it always present with a kind of fuzzy matching

[agersant]

Yeah, I'm afraid this will have to be implemented per audio format :c
My biggest worry would be having to actually read the audio data for some format (especially MP3), because that might hurt indexing speed a lot.

[jxs]

yeah, mp3 for example if it's VBR, from what i have read you have to calculate each frame duration using it's bitrate and size.
Yeah that might happen for sure, one alternative is to save the duration to the database and only scan each file once, if the path already exists on the database do not read it's values again, what do you think?

[agersant]

Hard to make a call without performance measurements. I think this is a good plan B if measuring duration is very slow compared to querying the DB for an existing entry (with the drawback of potentially leaving a bad duration in the DB if the file is ever updated).

[jxs]

Ok, so flac is easy and fast jxs@16ae131 I am going to look into mp3 today, if you want i can PR with this, else i will submit when mp3 is done :)

[agersant]

I would welcome a PR with just FLAC, baby steps!

[agersant]

This has been in for a while for mp3 and FLAC.