Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features planned for future #2

Open
1 of 12 tasks
aggarwalankush opened this issue Apr 6, 2017 · 16 comments
Open
1 of 12 tasks

Features planned for future #2

aggarwalankush opened this issue Apr 6, 2017 · 16 comments

Comments

@aggarwalankush
Copy link
Owner

aggarwalankush commented Apr 6, 2017

The goal of this weather app is to demo different ionic component in a nice working app. Contributions are welcome for any good feature.

Features planned for future releases:

@jamzi
Copy link
Contributor

jamzi commented Apr 24, 2017

Hey @aggarwalankush , I have some spare time and can help you with development of some of these features. I think that Ionic 3 has support for lazy loading now, so maybe we can start with this one.

@aggarwalankush
Copy link
Owner Author

@jamzi That would be great. Lazy loading should be fun to implement. You can take reference from https://docs.google.com/document/d/1vGokwMXPQItZmTHZQbTO4qwj_SQymFhRS_nJmiH0K3w/edit and https://github.com/driftyco/ionic-conference-app/tree/lazy-load/src. Let me know if you face any issue.

@jamzi
Copy link
Contributor

jamzi commented Apr 28, 2017

@aggarwalankush Great work on improving the lazy loading, man!. I would like to try with i18n implementation. I once contributed to ionic-super-starter template pack and they used ng-translate (https://github.com/driftyco/ionic-starter-super).

@refaelgold
Copy link

i follow you :) great job!!!

@NaraGitHub
Copy link

Just tried. Looks great

@sarthvader
Copy link

Hi @aggarwalankush , I have gained some fresh experience with Ionic and would really like to continue it by contributing to your weather app. I would like to start with the Login screen, for which I want to try Firebase, Facebook and Google+.

@aggarwalankush
Copy link
Owner Author

@sarthvader Regarding login screen, I would like to point out few things:

  1. Apple app store doesn't allow facebook/google login if app is not using any login features. To avoid this issue, simply showing user image in side menu would be good.
  2. After login, if we can save user state(cities user added, weather settings...) in firebase, it would be great. So when user logout and login to app, everything can be restored.

@pedrazacarlos
Copy link

@aggarwalankush Thank you so much for share your project, I was wondering which is the easiest way to receive the results in spanish. Regards

@aggarwalankush
Copy link
Owner Author

@pedrazacarlos @jamzi commented that he would like to implement i18n with ng-translate in this comment #2 (comment) I think that would be the best approach.

@hiteshpr
Copy link

hiteshpr commented Jan 6, 2018

@aggarwalankush Hi, I would like to work on adding the PWA Functionality to the App. I know Angular 2,4 well and now starting to learn Ionic.
Is there any Mailing channel for this project? like an active group on Gitter or Slack etc.

@aggarwalankush
Copy link
Owner Author

@hiteshpr thanks but there is no group for this project.

@sarthvader
Copy link

Hey Ankush,
I got super busy the past few months but I now I have enough time to work the login screen, if it isn't already done by someone else. Just wanted to clarify what you are looking for; have the user login using their emails ids the first time they open the app, store those emails in a database in firebase and then use those emails to remember user's last state.

@aggarwalankush
Copy link
Owner Author

Hey @sarthvader I think a login screen with facebook/google/email login should be good. Also, a skip button if the user doesn't want to login. And saving information in firebase sounds good.

@LUNBOX
Copy link

LUNBOX commented Mar 10, 2019

hi I got the app working par it doesn't pick up cities when I search for a city any ideas what's wrong

@aggarwalankush
Copy link
Owner Author

@LUNBOX make sure you have a google api key
https://github.com/aggarwalankush/ionic-mosum#getting-started

@permalytics
Copy link

permalytics commented Mar 30, 2019

Hi. I am trying your app under ionic 4

after adding "serve": "ionic-app-scripts serve", to "scripts" I could run

ionic serve --devapp w/o ERRORS but it looks like it gets no data. (API keys double checked, darksky reports some calls)

What am I doing wrong?

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants