Add option to disable dead letter queue #711
Conversation
|
Hi @m9rc1n, thanks for the contribution! Out of curiosity, what was the reason you needed to disable the DLQ in the project you were using this plugin? Was it just for simplicity or did you want to bring your own DLQ or something like that? It looks like the tests are failing because we are no longer hitting our test coverage target after adding the new branches. Would it be possible to write a test that confirms that the DLQ and associated IAM policies are not created when that attribute is set to false? There should be some examples in https://github.com/agiledigital/serverless-sns-sqs-lambda/blob/master/lib/serverless-sns-sqs-lambda.test.ts#L566 |
|
Hi @NoxHarmonium, Thanks for your reply. I will add tests and will get back to you shortly! |
m9rc1n
force-pushed
the
add-option-to-disable-dead-letter-queue
branch
from
5d1c457
to
12a694b
Compare
|
Hi, Test added 👍🏻 |
|
@NoxHarmonium could you check my MR? Tests were added but still not running. I have 1 more MR to publish |
|
Sorry for the delay @m9rc1n. Tests are passing and the change LGTM. I'll merge it now. |
|
Oh I forgot to check that the commits were in the right format for semantic release (e.g. https://www.conventionalcommits.org/en/v1.0.0/#summary) I'll force a release this time, but in the future commits should follow that standard |
- The original commits in PR #711 didn't follow the conventions needed for semantic release to do its job, so this should force the change to be included.
# [2.1.0](v2.0.1...v2.1.0) (2023-05-24) ### Features * empty commit to force release of [#711](#711) ([b090fa7](b090fa7))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Sure @NoxHarmonium, thanks for fixing it! |
No description provided.