Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply noise or remove it #3

Open
kwinkunks opened this issue Aug 7, 2021 · 2 comments
Open

Apply noise or remove it #3

kwinkunks opened this issue Aug 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kwinkunks
Copy link
Member

If our datasets are so clean that additive noise might be useful, then let's keep it and add it in to all of the examples. (It's not being used in the first sand/shale example.)

Or, if our datasets are already noisy, maybe we should just remove it, or at least rescale it so that the max is not so noisy.

@kwinkunks kwinkunks added the enhancement New feature or request label Aug 7, 2021
@kwinkunks kwinkunks added bug Something isn't working and removed enhancement New feature or request labels Sep 16, 2021
@kwinkunks
Copy link
Member Author

I think it is a nice feature, at least of the synthetic datasets — so we should make it do something for the real datasets.

Calling it a bug b/c I think that's how a user would see the current behaviour.

Alternative is to disable the slider (grey it out) for real datasets.

@kwinkunks
Copy link
Member Author

Disabled for custom datasets by 23423d1

It probably looks even more like a bug now though 😬

No change yet for real datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant