DM-1029: [App] Practice Page Geolocation Map #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclyde
approved these changes
Oct 31, 2019
| @@ -126,6 +126,7 @@ | |||
| <%= render partial: 'maps/home_map_data', formats: [:js] %> | |||
| <% end %> | |||
| <%= javascript_include_tag 'diffusion_history/home_map', 'data-turbolinks-track': 'reload' %> | |||
| <%= javascript_include_tag 'diffusion_history/_map_utilities', 'data-turbolinks-track': 'reload' %> | |||
There was a problem hiding this comment.
Nice, good to move these to a separate file
| expect(markers.count).to eq(17) | ||
| end | ||
| end | ||
| end |
aurora-a-k-a-lightning
added a commit
that referenced
this pull request
Mar 18, 2020
* DM-1029: start practice page map * DM-1029: status filters and e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
https://agile6.atlassian.net/browse/DM-1029
Description - what does this code do?
Adds the geolocation feature to the practice page
Testing done - how did you test it/steps on how can another person can test it
Make sure to have the GOOGLE_API_KEY and run the diffusion_history task
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
https://www.figma.com/file/DDUSxYiD1MaWNrGFmMjY8d8a/Diffusion-Marketplace-Designs?node-id=4%3A306
Acceptance criteria
Definition of done