Use $SSH_CONNECTION #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for your contribution, @jupl ! I'll play around with this on the dev branch for a couple of days. I'm half inclined to test for all three environment variables, just to be safe -- but I like to be economical, as well. |
|
@jupl I have merged your commit and added another of my own so that there are tests for all three environment variables. |
|
Ah. Got it. I will note that issue 2 is still present unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this for a while but recently noticed an inconsistency with showing the hostname. I'm using tmux, having one session when on the computer directly and a separate session when I connect via SSH. One of two scenarios occur:
If I start a session first in the computer directly, the hostname does not show. However, if I then start a session via SSH while the other session is still open the hostname still doesn't show.
If I start a session first via SSH, the hostname does show. However, if I then start a session directly while the other session is open the hostname still shows.
In both cases I observe the environment variables and it seems that
SSH_CLIENTandSSH_TTYare not reliable in determining if I'm in an SSH session. The only environment variable that is consistent isSSH_CONNECTION, plus other ZSH themes I've observed also useSSH_CONNECTION. I also tried usingSSH_CONNECTIONwithout tmux and it seems to work properly.