Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support connection strings #10

Closed
chiptech-kirk opened this issue Jul 5, 2023 · 2 comments
Closed

Please support connection strings #10

chiptech-kirk opened this issue Jul 5, 2023 · 2 comments

Comments

@chiptech-kirk
Copy link
Contributor

Hi there, I've put in a PR for supporting connection strings.
#9
This also allows using the package with Azurite.

Feel free to rework it if you feel it is too hacky putting the connection string in the account name property.

Thanks very much for the package by the way!
@agmoss
Copy link
Owner

agmoss commented Jul 17, 2023

Hi @chiptech-kirk, thanks for the flag. I have updated your pr with some better ergonomics for handling a connection string in the account type. I will merge and publish soon.

@agmoss
Copy link
Owner

agmoss commented Jul 24, 2023

Available in version 1.4.0 https://www.npmjs.com/package/winston-azure-blob/v/1.4.0

@agmoss agmoss closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agmoss @chiptech-kirk