Crash due to "Unknown Error"

[celer]

Hi, so we're seeing crash in the following function because serviceName, serviceType and replyDomain are NULL, which occurs when DNSServiceErrorType is -65537, aka "Uknown Error". We haven't figured out what is causing the unknown error, but regardless mdns shouldn't crash when this happens.

static
void
DNSSD_API
OnServiceChanged(DNSServiceRef sdRef, DNSServiceFlags flags, 
        uint32_t interfaceIndex, DNSServiceErrorType errorCode, 
        const char * serviceName, const char * serviceType,
        const char * replyDomain, void * context)
{
    HandleScope scope;
    ServiceRef * serviceRef = static_cast<ServiceRef*>(context);
    Handle<Function> callback = serviceRef->GetCallback();
    Handle<Object> this_ = serviceRef->GetThis();

    const size_t argc(8);
    Local<Value> args[argc];
    args[0] = Local<Object>::New(serviceRef->handle_);
    args[1] = Integer::New(flags);
    args[2] = Integer::New(interfaceIndex);
    args[3] = Integer::New(errorCode);
    args[4] = String::New(serviceName);
    args[5] = String::New(serviceType);
    args[6] = String::New(replyDomain);
    if (serviceRef->GetContext().IsEmpty()) {
        args[7] = Local<Value>::New(Undefined());
    } else {
        args[7] = Local<Value>::New(serviceRef->GetContext());
    }
    callback->Call(this_, argc, args);
}

Our fix is as so:

    if(serviceName)
      args[4] = String::New(serviceName);
    else
      args[4] = Local<Value>::New(Undefined());
    if(serviceType)
      args[5] = String::New(serviceType);
    else
      args[5] = Local<Value>::New(Undefined());
    if(replyDomain)
      args[6] = String::New(replyDomain);
    else
      args[6] = Local<Value>::New(Undefined());

[agnat]

Thanks for the report. I'll do a release after fixing the other callbacks accordingly.

[agnat]

Bugfix released in v0.0.7