Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ion modes need clarification #894

Open
kslong opened this issue Aug 6, 2021 · 1 comment
Open

Ion modes need clarification #894

kslong opened this issue Aug 6, 2021 · 1 comment

Comments

@kslong
Copy link
Collaborator

kslong commented Aug 6, 2021

The ionization modes need to be documented on Sphinx, and in addition we need to understand what we want the one that says on.the.spot to do.

As far as I can tell the on.the.spot ionization mode is one in which there is no attempt to balance heating and cooling and it sets t_e and t_r to t_r. As I recall, the origin LM approach set t_e to 0.9 t_r.

@kslong
Copy link
Collaborator Author

kslong commented Nov 8, 2021

Currently, there is an empty Sphinx page for the parameter. I have updated it

It is roughly here in ones local version of Python, assuming one reruns sphinx

docs/sphinx/html/input/parameters/wind/Wind/Wind.ionization.html#wind-ionization

and should hopefully get to

https://agnwinds.readthedocs.io/en/dev/input/parameters/wind/Wind/Wind.ionization.html#wind-ionization

@Higginbottom could you look at this page after locating it in your repository, and see if it needs updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants