New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type for prop 'preview' #34

Closed

voxtobox opened this issue Jul 4, 2018 · 1 comment

Contributor

voxtobox commented Jul 4, 2018 •

edited

Loading

First of all, thank you for the nice component which saved my time.
Please, fix type of property preview.
According to cropperjs docs preview can be

Element, Array (elements), NodeList or String (selector)

I'm passing ref, and it's works but with warning in console.

Owner

Agontuk commented Jul 5, 2018

Thanks, I'll look into it.

voxtobox added a commit to voxtobox/vue-cropperjs that referenced this issue


          change 'preview' prop types Agontuk#34

2120cde

voxtobox mentioned this issue

change 'preview' prop types #36

Merged

Agontuk closed this as completed in #36

Agontuk pushed a commit that referenced this issue


          change 'preview' prop types #34 (#36)

4d21fbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment