Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle errors (e.g. expressions that don't succeed)? #19

Open
agoose77 opened this issue Sep 14, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@agoose77
Copy link
Owner

  • Should we clear the cell attachments before requesting new values from the kernel?
  • Should we delete failed keys from the attachments after updating from the kernel?
  • Should there be a visual indicator, and if so, should it be different to the existing "no attachment" icon?
@agoose77 agoose77 added the enhancement New feature or request label Sep 14, 2021
@fcollonval
Copy link
Collaborator

* Should we clear the cell attachments before requesting new values from the kernel?

It makes sense to ensure the values displayed are consistent with the same call to the kernel.

* Should we delete failed keys from the attachments _after_ updating from the kernel?

I think we should keep some value for error for other tools (like nbconvert,...).

* Should there be a visual indicator, and if so, should it be different to the existing "no attachment" icon?

It would be great to be able to get the error from the kernel if possible to help correcting the expression.

@agoose77
Copy link
Owner Author

#23 takes care of storing the traceback information where expressions fail, and we now clear the (jupyterlab-imarkdown) attachments before asking the kernel for new values.

At present, the errors are just displayed in-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants