Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not work with "build/confirm_with_reveal.js"... #10

Closed
thierrymichel opened this issue Aug 19, 2014 · 3 comments
Closed

Do not work with "build/confirm_with_reveal.js"... #10

thierrymichel opened this issue Aug 19, 2014 · 3 comments

Comments

@thierrymichel
Copy link

But works correctly with "confirm.js" from the Project Page.
No errors into the console.
Just no confirmation modal, links are followed…

Anyway, thanks for sharing and for the job !

@jletourneau
Copy link
Contributor

Interesting. I did notice that the project page's version of the script doesn't have the latest updates from this commit, so presumably something in that change is what is causing it not to work for you.

A few questions:

  1. What version of ZURB Foundation are you using?
  2. Are you using this plugin in a Rails app alongside jquery_ujs.js?
  3. Do you have this page up at a publicly-viewable URL for debugging?

@LoveGal8
Copy link

Same problem for me.

I removed this part of the code to get it to work:

if (!el_options) {
return true;
}

When you just add "data-confirm" to an element, the line
el_options = $el.data('confirm');
obviously returns an empty string. So then the removed code above just returns true instead of continuing to the building of the modal etc.

Hope this helps!

@thierrymichel
Copy link
Author

Hi,

It is ok since your last commit.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants