Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly state the format of the template #14

Merged
merged 3 commits into from Feb 7, 2013
Merged

explicitly state the format of the template #14

merged 3 commits into from Feb 7, 2013

Conversation

fschwahn
Copy link
Contributor

Hi,
this pull request includes one important fix and two minor ones:

  1. State the format explicitly when rendering the error-partial. The reason is that I was getting errors when a route with a format was accessed, such as "http://www.domain.tld/stylesheets/base.css". Rails was complaining that there was no view with an css extension it could render.
  2. I relaxed the bundler requirement as I'm using bundler 1.1.rc
  3. I took the hardcoded string for the errship_standard and make it i18n.

@czarneckid
Copy link
Collaborator

Looks good to me 👍

logankoester added a commit that referenced this pull request Feb 7, 2013
explicitly state the format of the template
@logankoester logankoester merged commit 4b417c5 into logankoester:master Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants