Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rekeyed account support #226

Closed
kieranroneill opened this issue May 11, 2024 · 0 comments · Fixed by #240
Closed

Rekeyed account support #226

kieranroneill opened this issue May 11, 2024 · 0 comments · Fixed by #240
Assignees
Labels
✨ feature New feature or request
Milestone

Comments

@kieranroneill
Copy link
Contributor

kieranroneill commented May 11, 2024

Summary

Re-keyed accounts are a very core feature of AVM and are one of the final features of the Kibisis that must be implemented for Kibisis to be a fully compliant wallet.

This task sets up support for re-keyed accounts by displaying when an account is re-keyed, when the account is re-keyed without the auth account present (i.e. a watch account) and using the re-keyed auth account when signing transactions.

Acceptance criteria

Scenario 1: User sees a re-key account
GIVEN a User adds an account that is rekeyed with an account present in the account list
WHEN the User loads up Kibisis
THEN the a re-key badge appears on the re-keyed account in the side bar
AND a "Re-key" badge appears on the account page

Scenario 1: User sees a re-key account as a watch account
GIVEN a User adds an account that is rekeyed with an account that is not present in the account list
WHEN the User loads up Kibisis
THEN the a re-key account badge and a watch account badge appears on the re-keyed account in the side bar
AND a "Re-key" account badge appears on the account page with a warning
AND a "Watch" account badge on the account page

Notes

  • Re-keyed accounts whose auth address is not present in the account list, or whose auth address is a watch account, MUST be treated as a watch account.
@kieranroneill kieranroneill self-assigned this May 11, 2024
@kieranroneill kieranroneill added the ✨ feature New feature or request label May 11, 2024
@kieranroneill kieranroneill added this to the v1.17.0 milestone May 11, 2024
@kieranroneill kieranroneill changed the title Import a rekeyed account Display a rekeyed account May 19, 2024
@kieranroneill kieranroneill changed the title Display a rekeyed account Rekeyed account support May 20, 2024
@kieranroneill kieranroneill linked a pull request May 23, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant