Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to the guild.join method to select platform #9

Closed
KevinLu opened this issue May 11, 2022 · 3 comments
Closed

Add an option to the guild.join method to select platform #9

KevinLu opened this issue May 11, 2022 · 3 comments

Comments

@KevinLu
Copy link

KevinLu commented May 11, 2022

Currently, only the guildId can be passed to the guild.join method, as seen here:
https://github.com/agoraxyz/guild-sdk/blob/66120a1bcbb6bc1b257e1dde490fd4d10328fa65/src/client.ts#L156-L175

However, this won't return the inviteLink and alreadyJoined properties as specified by the type JoinResponse:
https://github.com/agoraxyz/guild-sdk/blob/66120a1bcbb6bc1b257e1dde490fd4d10328fa65/src/types.ts#L8-L11

Can platform and platformUserId be added to guild.join? For example, this is a valid payload:

{
  guildId: 481
  platform: "DISCORD"
  platformUserId: "965726448839163915"
}
@ejayxyz
Copy link
Contributor

ejayxyz commented May 11, 2022

Thanks for these issues and reports! Currently, we are refactoring and modularize our backend, and the SDK will change in a few ways. We should wait until those changes are live, then after that we will check back to these issues.

@KevinLu
Copy link
Author

KevinLu commented May 11, 2022

Thanks for the reply @ejayxyz , when the backend refactor is complete, will there be breaking changes to this SDK? Can you provide an ETA on the backend refactor?

@ejayxyz
Copy link
Contributor

ejayxyz commented May 11, 2022

@KevinLu I would say, we could finish these changes in 2 weeks or so. A few things will change, but not sure about any related breaking change yet. If you create, or manage anything through the SDK, you might have to refactor a bit as well. We are too early to version these things, I would say, but we will think about it.

@guildxyz guildxyz deleted a comment from armandRobled Mar 19, 2024
@ejayxyz ejayxyz closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants