Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App cannot be built in docker image 'electronuserland/builder:wine' #17

Closed
Ben305 opened this issue May 17, 2018 · 5 comments
Closed

App cannot be built in docker image 'electronuserland/builder:wine' #17

Ben305 opened this issue May 17, 2018 · 5 comments

Comments

@Ben305
Copy link

Ben305 commented May 17, 2018

I'm trying to build my electron app using the well-known docker image.

The following error occurs when the dependencies are installed:

> edge-cs@1.2.1 install /builds/project-0/Client/node_modules/edge-cs
> node tools/install.js


> electron-edge@6.5.5 install /builds/project-0/Client/node_modules/electron-edge
> node tools/install.js

make: Entering directory '/builds/project-0/Client/node_modules/electron-edge/build'
  CXX(target) Release/obj.target/edge_nativeclr/src/mono/clractioncontext.o
  CXX(target) Release/obj.target/edge_nativeclr/src/mono/clrfunc.o
../src/mono/clrfunc.cpp: In static member function ‘static v8::Local ClrFunc::Initialize(MonoObject*)’:
../src/mono/clrfunc.cpp:55:102: warning: ‘static v8::Local v8::Script::Compile(v8::Local, v8::ScriptOrigin*)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         v8::Local codeFunction = v8::Local::Cast(v8::Script::Compile(code)->Run());
           ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:1235:38: note: declared here
                        Local<Script> Compile(Local source,
                                      ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp:55:109: warning: ‘v8::Local v8::Script::Run()’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         v8::Local codeFunction = v8::Local::Cast(v8::Script::Compile(code)->Run());
                  ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:1250:51: note: declared here
   V8_DEPRECATED("Use maybe version", Local Run());
                                                   ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE ClrFunc::Initialize(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/mono/clrfunc.cpp:80:54: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
         String::Utf8Value assemblyFile(jsassemblyFile);
                                                      ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
                   explicit Utf8Value(Local obj));
                            ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp:81:105: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
         String::Utf8Value nativeTypeName(options->Get(Nan::New("typeName").ToLocalChecked()));
              ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
                   explicit Utf8Value(Local obj));
                            ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp:82:109: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
         String::Utf8Value nativeMethodName(options->Get(Nan::New("methodName").ToLocalChecked()));
                  ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
                   explicit Utf8Value(Local obj));
                            ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp:95:103: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
         String::Utf8Value compilerFile(options->Get(Nan::New("compiler").ToLocalChecked()));
            ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
                   explicit Utf8Value(Local obj));
                            ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/mono/clrfunc.cpp: In static member function ‘static v8::Local ClrFunc::MarshalCLRExceptionToV8(MonoException*)’:
../src/mono/clrfunc.cpp:365:55: error: no matching function for call to ‘v8::Object::SetPrototype(v8::Local)’
     result->SetPrototype(v8::Exception::Error(message));
                                                       ^
In file included from ../src/mono/../common/edge_common.h:4:0,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:3308:37: note: candidate: v8::Maybe v8::Object::SetPrototype(v8::Local, v8::Local)
   V8_WARN_UNUSED_RESULT Maybe SetPrototype(Local context,
                                     ^
/root/.node-gyp/10.1.0/include/node/v8.h:3308:37: note:   candidate expects 2 arguments, 1provided
../src/mono/clrfunc.cpp: In static member function ‘static MonoObject* ClrFunc::MarshalV8ToCLR(v8::Local)’:
../src/mono/clrfunc.cpp:493:48: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
             v8::String::Utf8Value utf8name(name);
                                                ^
In file included from /root/.node-gyp/10.1.0/include/node/v8.h:26:0,
                 from ../src/mono/../common/edge_common.h:4,
                 from ../src/mono/edge.h:4,
                 from ../src/mono/clrfunc.cpp:1:
/root/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
                   explicit Utf8Value(Local obj));
                            ^
/root/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
edge_nativeclr.target.mk:110: recipe for target 'Release/obj.target/edge_nativeclr/src/mono/clrfunc.o' failed
make: Leaving directory '/builds/project-0/Client/node_modules/electron-edge/build'
make: *** [Release/obj.target/edge_nativeclr/src/mono/clrfunc.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:235:12)
gyp ERR! System Linux 4.9.87-linuxkit-aufs
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /builds/project-0/Client/node_modules/electron-edge
gyp ERR! node -v v10.1.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok

Does anybody know what's wrong here?
@agracio
Copy link
Owner

agracio commented May 17, 2018 •
edited
Loading

Edge.js has it's own system requirements besides the ones required to run Electron.
You installs script appears to refer to 'electron-edge' npm component, please make sure to open an issue there, this issue board is for 'electron-edge-js'

@agracio
Copy link
Owner

agracio commented May 18, 2018 •
edited
Loading

The issue is related to Node.js 10.x, there is a fix for it on edge-js code base but it is not yet released to NPM, I will merge the fix to electron-edge-js in the next few days and release both on NPM.
Alternatively downgrade Node.js in docker image to below 10.x

@Ben305
Copy link
Author

Ben305 commented May 18, 2018

Great, thanks!!!

@agracio
Copy link
Owner

agracio commented May 18, 2018

Try with electron-edge-js version 8.3.3

@Ben305
Copy link
Author

Ben305 commented May 18, 2018

Looks much better now. Thanks your fixing this blazing fast!

@Ben305 Ben305 closed this as completed May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ben305 @agracio