Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging for Windows from Mac or Linux #20

Closed
DionDavid opened this issue Jun 1, 2018 · 5 comments
Closed

Packaging for Windows from Mac or Linux #20

DionDavid opened this issue Jun 1, 2018 · 5 comments

Comments

@DionDavid
Copy link

Hey Agracio,

My app is targeting different platforms, including Windows, Linux and macOS (both ia32 and x64) and modern Node versions. The app doesn't have any platform-specific behavior.

If I install the project's dependencies using npm install, electron-edge-js downloads binaries just for the current platform (let's say win32, x64, Node v8.1).

Could you maybe make your package node-pre-gyp ready? So I can create packages from any platform for any platform?

Yours Sincerely,

Dion David

@agracio
Copy link
Owner

agracio commented Jun 1, 2018

You need to package it separately for each platform. The binaries included with electron-edge-js are are for all supported Node.js versions for Windows, there are no precompiled versions for Linux and macOS. On those platforms you need to run npm install to create the appropriate binaries.

@DionDavid
Copy link
Author

Ah the problem is that I have to package for every platform from a linux environment. Do you know how I can achieve this integration regarding your package?

@agracio
Copy link
Owner

agracio commented Jun 1, 2018

Don't know if that can be done. It's unlikely that a binary compiled on Linux will work on macOS.

@vudzero
Copy link

vudzero commented Aug 3, 2019

I also need to be able to build any platform from Linux. Libraries like drivelist, serialport and usb-detection do support pre built binary for most of the platforms which make it possible to build from any platform without having to compile at build.

Would it be possible to consider pre building binaries, at least for windows?

Example:
image

@Hammster
Copy link

Hammster commented Aug 3, 2019

@MatxBerg There are prebuild binaries for Windows.

@agracio Though to touch this topic slightly, I think we should use a CI and prebuild to serve the built .node libraries for the relevant node and electron releases only. The biggest benefit is that we do make the package smaller by letting a script download the correct .node file via prebuild and also allow to build the whole application on any system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants