New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recorder stop is not executed #2
Comments
It works in the demo and passes the proper tests: https://agrasley.github.io/react-audio-example/. You'll have to give me more information. |
This is actually a browser-level issue. The recording indicator doesn't go away even when the recording is technically stopped. As long as you're using the |
Well if this is the browser then indeed nothing can be done. (Strange that I debugged it and it didn't seem to go to the react-recorder component's stop method.) Thank you for the help! |
That is not correct, the recording indicator should stop when all the tracks have been stopped. You are correct in that when getUserMedia has been requested on a page that an indicator remains however it's not the recording indicator, its the camera icon to the right in the URL bar. I cannot reproduce this issue in Chrome, I suspect it's the react library not doing the right thing as indicated in @whiteadi's comment. |
When I run it in the debugger it shows that the state of the MediaRecorder switches from "recording" to "inactive" when I call MediaRecorder.stop(). Do I need some additional behavior? |
I also debugged it but it didn't go there to actually call the stop on the MediaRecorder, I end up using: https://webrtc.github.io/samples/src/content/getusermedia/volume/ Thanks anyway ;) |
@agrasley do you have any mediaStreams left alive? |
Hi,
I debugged and it does not ever comes into the react-recorder stop function if you dispatch the @@react-recorder/STOP action calling recorderStop.
Regards,
Adrian
The text was updated successfully, but these errors were encountered: