Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recorder stop is not executed #2

Closed
whiteadi opened this issue Jan 17, 2017 · 8 comments
Closed

recorder stop is not executed #2

whiteadi opened this issue Jan 17, 2017 · 8 comments

Comments

@whiteadi
Copy link

whiteadi commented Jan 17, 2017

Hi,

I debugged and it does not ever comes into the react-recorder stop function if you dispatch the @@react-recorder/STOP action calling recorderStop.
Regards,
Adrian

@whiteadi whiteadi changed the title recrder stop is not executed recorder stop is not executed Jan 17, 2017
@agrasley
Copy link
Owner

It works in the demo and passes the proper tests: https://agrasley.github.io/react-audio-example/. You'll have to give me more information.

@whiteadi
Copy link
Author

Hi,

and thanks for reply,

it does stop the drawing (VolumeMeter) but not the recording or at least I cannot see it going into rect-recorder stop method and anyway more important the recording icon is on, please check yourself when pressing stop if it disappear, check also my attached screenshot.
screen shot 2017-01-20 at 08 39 48

@agrasley
Copy link
Owner

This is actually a browser-level issue. The recording indicator doesn't go away even when the recording is technically stopped. As long as you're using the getUserMedia API call, the recording icon is visible in the browser tab, even if you're not actually doing anything with that recording object. So the recording process does in fact stop, it just doesn't make the indicator go away.

@whiteadi
Copy link
Author

Well if this is the browser then indeed nothing can be done. (Strange that I debugged it and it didn't seem to go to the react-recorder component's stop method.) Thank you for the help!

@KaptenJansson
Copy link

That is not correct, the recording indicator should stop when all the tracks have been stopped. You are correct in that when getUserMedia has been requested on a page that an indicator remains however it's not the recording indicator, its the camera icon to the right in the URL bar.

I cannot reproduce this issue in Chrome, I suspect it's the react library not doing the right thing as indicated in @whiteadi's comment.

@agrasley
Copy link
Owner

When I run it in the debugger it shows that the state of the MediaRecorder switches from "recording" to "inactive" when I call MediaRecorder.stop(). Do I need some additional behavior?

@whiteadi
Copy link
Author

I also debugged it but it didn't go there to actually call the stop on the MediaRecorder, I end up using: https://webrtc.github.io/samples/src/content/getusermedia/volume/

Thanks anyway ;)

@KaptenJansson
Copy link

@agrasley do you have any mediaStreams left alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants