Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Running two instances comingles output #214

Open
2 tasks done
jacobdadams opened this issue Aug 25, 2023 · 5 comments
Open
2 tasks done

[Bug]: Running two instances comingles output #214

jacobdadams opened this issue Aug 25, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jacobdadams
Copy link
Member

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

App Version

1.6.7

Electron Version

25.2.0

Operating System

Windows

What happened?

If two instances of the api client are geocoding at the same time, the output for each contains a mixture of results from each process. Depending on when each one starts and finishes, one output may just have extra rows from the other process, or rows get completely stomped on by the other process.

If independent parallel execution is deemed not supportable, is there a way to check the client is already running?

Steps To Reproduce

  1. Start an instance and start geocoding
  2. Start another instance and start geocoding another file that will finish first
  3. The second file will have rows from the first

Relevant log output

No response

@jacobdadams jacobdadams added the bug Something isn't working label Aug 25, 2023
@steveoh
Copy link
Member

steveoh commented Aug 25, 2023

I'm leaning towards this isn't a bug and only one instance should be run at a time. Do you run more than one instance to make it go faster? That sort of defeats the intention and goals of the app.

@jacobdadams
Copy link
Member Author

I have a bunch of files I need to geocode, so I was trying to do them in parallel. I was curious if it would let me open a second instance and what the result would be.

@stdavis
Copy link
Member

stdavis commented Aug 28, 2023

This is where a CLI would be nice.

@steveoh
Copy link
Member

steveoh commented Aug 28, 2023

Explain your thoughts on a cli?

@stdavis
Copy link
Member

stdavis commented Aug 28, 2023

I'm not sure if this is possible. But it would be cool if this app came with a cli. So that you could run a job from the command line.

ugrc-api-client geocode ./Addresses.csv

I'm not sure how the field mapping would work. I just thought that for folks that needed a repeatable process it would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants