Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Licensed Health Care Facilities from Dept of Health #257

Open
19 of 24 tasks
Tracked by #426
ZachBeck opened this issue Aug 10, 2023 · 21 comments
Open
19 of 24 tasks
Tracked by #426

Add Licensed Health Care Facilities from Dept of Health #257

ZachBeck opened this issue Aug 10, 2023 · 21 comments
Labels
introduction new data and services are being introduced porter issue related to adding and removing data and services

Comments

@ZachBeck
Copy link
Member

ZachBeck commented Aug 10, 2023

Summary

  • Proposed Readable Name: Utah Licensed Health Care Facilities
  • Proposed Internal Dataset Name: SGID.HEALTH.LicensedHealthCareFacilities
  • Proposed External Dataset Name: opensgid.health.licensedhealth_care_facilities
  • Proposed Data Category: HEALTH
  • Data Description: Licensed health care facilities in Utah
  • Source Agency/Entity: Health
  • Contact: None
  • Update Frequency: Yearly

This will replace the existing, soon to be deprecated SGID.HEALTH.HealthCareFacilities. This data has been geocoded from licensed health providers and will have the same source as the current HealthCareFacilities but a different schema that will be easier to maintain.

The data should be available in

1 Check [x] all the areas where you expect the data to show up.

  • Internal SGID
  • Open Data
  • Open SGID
  • ArcGIS Online

The data is of high quality

Where is the data source

Choose one.

Action items

  1. Assign a person who should complete the task by replacing name with their github @name.
  2. Check [x] the box when the task is completed and add the date of completion.
  3. Strike out all items that do not apply.

🤖 Automation validation

  1. Assign yourself or someone to check the item by replacing name with their github @name.
  2. Check [x] the box and add the date of verification 2020/01/01 when the task is verified.
  3. Strike out all items that do not apply.

Notification

Group Task Assignments

  1. Check [x] the box when you have assigned all the tasks relevant to your group.
@ZachBeck ZachBeck added introduction new data and services are being introduced porter issue related to adding and removing data and services labels Aug 10, 2023
@steveoh
Copy link
Member

steveoh commented Aug 11, 2023

It seems a little odd to me to use the same table name in the deprecation and addition since any existing references will still be correct but the schema will be completely incompatible. I'm not sure what the best advice is on the naming since the current name is ideal but it should change.

@ZachBeck
Copy link
Member Author

Definitely not ideal but we have done it in the past with Soils. I haven't been able to dream up a name that's more descriptive than HealthCareFacilities.

@agrc agrc deleted a comment from agrc-conductor Aug 14, 2023
@steveoh
Copy link
Member

steveoh commented Aug 14, 2023

We had a similar conversion with soils and the situation was a little different. This is worth a group discussion to come up with a consistent path forward for this occurrence and all future ones.

@ZachBeck
Copy link
Member Author

I added a discussion item in tomorrow's team meeting.

@ZachBeck
Copy link
Member Author

@steveoh do we have any metrics on open-sgid tracking what gets used and how often? In deprecation/addition cases where the schema changes but the name stays the same we decided to add _deprecated to the feature class name as part of the soft delete process.

@steveoh
Copy link
Member

steveoh commented Aug 15, 2023

do we have any metrics on open-sgid tracking what gets used and how often?

We sorta do but no there isn't. Everyone has access to view all the data available for the cloudsql instance. To read between the lines, there should be a consistent process independent of popularity.

In deprecation/addition cases where the schema changes but the name stays the same we decided to add _deprecated to the feature class name as part of the soft delete process.

I thought the soft delete unshared the item/deleted the table? What does renaming the table accomplish differently? Would that only work for open data/arcgis online?

The open sgid connection will break during the soft delete, like it normally would, and will look correct after the same table name is added again. How does _deprecated address this issue?

Any api search requests or open sgid layer in a project that goes unnoticed, and let's be honest, our reach for these deprecations is not great, will query the same table the entire time. The error message in the api will change from this table doesn't exist, which is correct, to this attribute doesn't exist on this table, which is confusing. I'm not sure what pro/map/qgis/etc would do. This seems like a poor solution that I can't support since it doesn't cover all of the sgid.

Suffixing the table with v2 seems like a better alternative. Or keeping the original schema and adding the new columns to not create a breaking change is an option. I really don't think there should ever be a deprecation and addition with the same name. It's not consistent enough.

@ZachBeck
Copy link
Member Author

I think a deprecation/addition with the same name, though not ideal, is a fact of life. To me having intuitive naming conventions that make sense is better in the long run and make up for whatever short term disruption that a user experiences.

Adding _deprecated to the name in open-sgid is a way of letting the user realize that there has been a change in the data and discover the new version when they repair the link. Not ideal, but at least they are presented with the new vs old feature class.

I think appending new fields on to the existing schema isn't a viable solution. That leaves us either trying to maintain fields that no longer exist in the stewards data or having columns in the table that only have null values.

It sounds like this needs to be discussed at the next dev/data meeting.

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
@rkelson has completed 0 out of 1 tasks

@nathankota
Copy link
Contributor

the strategy

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
@rkelson has completed 0 out of 1 tasks

2 similar comments
@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
@rkelson has completed 0 out of 1 tasks

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
@rkelson has completed 0 out of 1 tasks

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
@rkelson has completed 0 out of 1 tasks

@steveoh steveoh added the blocked Certain tasks are blocking progress (conductor will skip checks) label Sep 19, 2023
@steveoh
Copy link
Member

steveoh commented Sep 19, 2023

Adding blocked since work hasn't started on this yet.

@ZachBeck
Copy link
Member Author

ZachBeck commented Nov 7, 2023

Waiting on updated facilities from Health.

@nathankota nathankota removed the blocked Certain tasks are blocking progress (conductor will skip checks) label Jun 3, 2024
@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@brigsz has completed 0 out of 1 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
rkelson has completed 1 out of 1 tasks 👍

@brigsz
Copy link
Member

brigsz commented Jun 13, 2024

This does not yet have a record series, I will find out how to create one

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@brigsz has completed 0 out of 1 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
rkelson has completed 1 out of 1 tasks 👍

1 similar comment
@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@brigsz has completed 0 out of 1 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
rkelson has completed 1 out of 1 tasks 👍

@ZachBeck ZachBeck changed the title Add Health Care Facilities from Dept of Health Add Licensed Health Care Facilities from Dept of Health Jun 24, 2024
@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 0 out of 6 tasks
@brigsz has completed 0 out of 1 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
@jacobdadams has completed 0 out of 1 tasks
@gregbunce has completed 0 out of 1 tasks
rkelson has completed 1 out of 1 tasks 👍

@agrc-conductor
Copy link

conductor results for tasks - 257

check status
@ZachBeck has completed 6 out of 9 tasks
@brigsz has completed 0 out of 1 tasks
@steveoh has completed 0 out of 4 tasks
@stdavis has completed 0 out of 1 tasks
jacobdadams has completed 1 out of 1 tasks 👍
@gregbunce has completed 0 out of 1 tasks
rkelson has completed 1 out of 1 tasks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
introduction new data and services are being introduced porter issue related to adding and removing data and services
Projects
None yet
Development

No branches or pull requests

5 participants