Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp immutability improvements #645

Closed
2 tasks
andrus opened this issue Jul 30, 2023 · 1 comment
Closed
2 tasks

Exp immutability improvements #645

andrus opened this issue Jul 30, 2023 · 1 comment

Comments

@andrus
Copy link
Contributor

andrus commented Jul 30, 2023 •
edited
Loading

After #602 , our expressions are outwardly immutable. Now we can tweak a few internals to make the API more clean, be consistent between parsed and manually-created expressions and avoid extensive "deepCopy" on assembly:

  • Remove SimpleNode.parent property (will require making SimpleNode.jjtSetParent() a noop). One step to avoid deep copy
  • Somehow "freeze" child changes. Final step to avoid deep copy.
@andrus andrus mentioned this issue Jul 30, 2023
Merged
@andrus
Copy link
Contributor Author

andrus commented Sep 27, 2023

Let's put this on hold. We have other things to work on.

@andrus andrus closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrus