Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ids #27

Closed
1 of 6 tasks
bibo38 opened this issue Jun 29, 2017 · 2 comments
Closed
1 of 6 tasks

Duplicate ids #27

bibo38 opened this issue Jun 29, 2017 · 2 comments
Labels
enhancement

Comments

@bibo38
Copy link
Contributor

bibo38 commented Jun 29, 2017 •
edited
Loading

I have just searched this repository for duplicate IDs and found the following:

  • coffee_plant
  • rice_plant
  • barley_plant
  • cotton_plant
  • beet_plant
  • farmland_soil

Instead of just renaming every plant, I would suggest a namespace feature.
Example usage may be:

  • When referencing a plant, we just use the current folder as the namespace. E.g. Referencing beet_plant in the vanilla folder leads to the search for "vanilla:beet_plant"
  • Referencing from other mods may be like "harvestcraft:beet_plant" or "vanilla:beet_plant"
@bibo38 bibo38 mentioned this issue Jun 29, 2017
Closed
@RlonRyan
Copy link
Member

RlonRyan commented Jul 4, 2017

Yeah... I really should add domains to the loader.

bibo38 added a commit to bibo38/AgriPlants that referenced this issue Jul 6, 2017
@bibo38
Removed duplicate farmland_soil
b51fd91 
A exact duplicate of the farmland soil from vanilla minecraft is present in the
mystical_agricultures mod directory. This causes a duplicate id like
described in AgriCraft#27.
@bibo38 bibo38 mentioned this issue Jul 6, 2017
Merged
@TokkenGmr TokkenGmr mentioned this issue Jul 27, 2017
Closed
@TokkenGmr
Copy link
Contributor

A PR has been made that removes the extra farmland_soil JSON. As well as a change to the vanilla beet JSON that will eliminate those duplicates

RlonRyan pushed a commit that referenced this issue Feb 26, 2018
@bibo38 @RlonRyan
Removed duplicate farmland_soil (#32)
983f399 
A exact duplicate of the farmland soil from vanilla minecraft is present in the
mystical_agricultures mod directory. This causes a duplicate id like
described in #27.
@TokkenGmr TokkenGmr mentioned this issue Feb 28, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bibo38 @RlonRyan @TokkenGmr