BaseExceptionGroup.derive should not copy __notes__ #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes the behaviour follow that of CPython more closely. Instead, copy __notes__ (if present) in the *callers* of derive. The (modified) test passes now, and it passes on py3.11. It fails before the changes.
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 8155139303Details
💛 - Coveralls |
|
Does anything here actually test that |
…tes' into derive-doesnt-copy-notes
The test changes that I did tests it, but very indirectly. So I've now added an explicit test. |
|
Thanks! |
jakkdl
added a commit
to jakkdl/exceptiongroup
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the behaviour follow that of CPython more closely. Instead, copy notes (if present) in the callers of derive. The (modified) test passes now, and it passes on py3.11. It fails before the changes. #111