Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream changes #19

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 6 comments
Closed

Sync with upstream changes #19

GoogleCodeExporter opened this issue Mar 14, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

The concurrent.futures module in cpython has had some changes since this 
backport was released; it would be good to sync up with cpython 3.3.  I'm 
particularly interested in this change:
  http://hg.python.org/cpython/annotate/4390d6939a56/Lib/concurrent/futures/thread.py#130
which prevents a 100ms delay when shutting down a ThreadPoolExecutor.

Original issue reported on code.google.com by ben.darn...@gmail.com on 23 May 2013 at 3:28

@GoogleCodeExporter
Copy link
Author

would be great to sync with upstream, I am looking for this one:

http://hg.python.org/cpython/rev/6d6099f7fe89
Issue #9205: concurrent.futures.ProcessPoolExecutor now detects killed

Original comment by taylorba...@gmail.com on 1 Oct 2013 at 9:58

@GoogleCodeExporter
Copy link
Author

Detecting dead processes is really important since otherwise things just hang 
indefinitely.  There isn't a workaround (eg trying to examine 
ProcessPoolExecutor internal state).

Original comment by rogerbinns on 11 Apr 2014 at 5:09

@GoogleCodeExporter
Copy link
Author

Agreed, the lack of support for "Detecting dead processes" means that I can't 
use the backport in a production environment.

Original comment by jtobe...@gmail.com on 1 Jul 2014 at 3:28

@harlowja
Copy link

harlowja commented May 6, 2015

👍 to this, there have been some changes that have been flushing through upstream to fix bugs that would be great to have incorporated here (if they haven't already been).

@agronholm
Copy link
Owner

Issue 21362 is the only one that is actually fixable -- the rest have either been fixed already or unfixable due to upstream code using py3 specific features.

@agronholm
Copy link
Owner

I'm closing this as wontfix because 21362 has been fixed here already and the rest are not fixable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants