-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreadPoolExecutor should fail when max_worker is 0 #55
Comments
The backport is a backport of Python 3.2's ThreadPoolExecutor. That said, I guess this is trivial enough to incorporate in the backport. |
You're right, there is no error in python 3.2. I just wanted to let you know because I came into it, but I don't think it is crucial ;) |
well, why does this backport keep API of py32 which is too old for production use. |
The changes made in the newer versions of concurrent.futures require Python core changes to work. That's why I haven't backported any newer versions. For reliable process pools, you must upgrade to Python 3.x. As for this particular change, I'll make it happen this week when I have the time. |
Fixed in 0913853. |
Aha, thanks very much for such a quick response, and sorry for the late regards. |
I noticed a difference when instantiated the executor with
ThreadPoolExecutor(max_workers=0)
.The backport does not raise, whereas the 3.5 raises a ValueError:
The text was updated successfully, but these errors were encountered: