Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetStatus fails due to unsupported zoom #103

Closed
bartbutenaers opened this issue Jun 17, 2018 · 11 comments
Closed

GetStatus fails due to unsupported zoom #103

bartbutenaers opened this issue Jun 17, 2018 · 11 comments

Comments

@bartbutenaers
Copy link

Dear,

I have a Panasonic VT-164 camera, which has limited PTZ support (pan and tilt are supported but not zoom).

When I call getStatus, I get an error: "Cannot read property '$' of undefined"

The full stack trace:

image

The response of getStatus is OK, however the error is caused by the res.position.zoom which is undefined:

image

Would appreciate if somebody could fix this.

Thanks in advance !!
Bart Butenaers

@bartbutenaers
Copy link
Author

Dear,

Panasonic's missing zoom functionality causes other errors.
When calling getConfigurationOptions this exception is raised:

image

Now the problem is caused by sp['absoluteZoomPositionSpace'] being undefined:

image

I assume the same problem will also occur when using relative, continious, ...

Bart

@RogerHardiman
Copy link
Collaborator

Have you implemented a workaround that you want to merge into the main project?

@bartbutenaers
Copy link
Author

Hi Roger (@RogerHardiman ),

To be honest I got the impression that this project wasn't actively maintained anymore, so I stopped my developments to integrate this node into the Node-RED IOT framework.

But if you are still interested, I can resume my work next year and create a pull request.

Hope to hear from you again soon!
Bart

@RogerHardiman
Copy link
Collaborator

You are right that there is not much going on with the library right now.
In my case I made all the changes I needed to the library to support a few of my projects and have not been doing any active development work.

I use use the library in my "ONVIF Audit" tool which scans the network and take a JPEG snapshot from each camera and I did have to make some changes this morning to fix an issue with a HikVision camera.

So when you are ready we can have a look at the Panasonic camera.
It would be good to fix the problem.

Thanks
Roger

@bartbutenaers
Copy link
Author

Ok Roger,
good to know you are still hanging out here :-) I will try to create a pull request in the beginning of next year.
Thanks!
Bart

@RogerHardiman
Copy link
Collaborator

great.
Also if you can make the camera available via the internet (just port forwarding Port 80) then I can connect from here. You'd need to PM me the details.
Roger

@RogerHardiman
Copy link
Collaborator

Hi
Do you still have the camera. If you can give me some remote access I can take a look and fix the problem.
Thanks
Roger

@bartbutenaers
Copy link
Author

Hi Roger,
thanks for the response! And BTW thanks for fixing the event stream. Will try to test it as soon as possible. My Onvif developments have been un hold for more than a year ;-(
Will get back to you soon!
Bart

@RogerHardiman
Copy link
Collaborator

RogerHardiman commented Nov 25, 2019

Have just pushed commit ca10a0c which is the first fix for your Panasonic camera, it changes getSystemDateAndTime to try with authentication.
I now get this in Example2.js for your camera...

Info: = {"manufacturer":"Panasonic","model":"BL-VT164","firmwareVersion":1.45,"serialNumber":"xxxxxx","hardwareId":"00"}

@RogerHardiman
Copy link
Collaborator

I have imported lodash into the project. Now I can use their _get command to safely check a path to item in an object is valid and insert a default value if is not valid.
This lets me check if a camera has Zoom without lots of if statements.

Anyway getStatus is now fixed and tested with a few cameras in the office.
Just have getConfigurationOptions to do next.

@RogerHardiman
Copy link
Collaborator

getConfigurationOptions is fixed in commit edeede6
getStatus was fixed in commit b6de685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants