Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve charts with no data #56

Closed

Conversation

luisfmelo
Copy link
Contributor

close #33

@simhnna
Copy link
Contributor

simhnna commented Mar 20, 2018

The change is ok.
But the category charts are still just white boxes when no data is available. I can merge this as is, or you can add them to this branch if you want.

Could you please always start your branches from origin/master so that the merge only includes commits for that issue. In this branch you have quite a few other commits.
It looks like 1add257 is the only commit relevant here. Can you start a new branch and cherry-pick that commit?

My personal preference is to rebase and not merge where possible. When I need to update a branch with commits from master I usually try to rebase. If it is too complicated I can still abort and do a normal merge, often a rebase just works.

@simhnna simhnna closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve charts when no data is available
2 participants