Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiproc is star_hsml unaware for same snapshot #8

Open
agurvich opened this issue Dec 17, 2018 · 2 comments
Open

multiproc is star_hsml unaware for same snapshot #8

agurvich opened this issue Dec 17, 2018 · 2 comments

Comments

@agurvich
Copy link
Owner

multiprocessing on multiple perspectives will compute smoothing lengths for each perspective even though you only have to compute them once... should put a flag or something to check if this is going to happen before mapping to the pool.

@agurvich
Copy link
Owner Author

this is a comment for interpolator and star_movie_maker though star_movie_maker can't loop through multiple perspectives from the command line anyway right now...

@agurvich
Copy link
Owner Author

This shouldn't happen now that getHSML is @metadata_cache'd. I'll need to make sure that only one thread actually computes it for the first time though, then they should all be able to read the smoothing lengths. Leaving open as a reminder.

@agurvich agurvich added the bug label Jul 20, 2020
@agurvich agurvich added enhancement and removed bug labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant